No reviewers
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index!364
Loading…
Reference in a new issue
No description provided.
Delete branch "train-037-blockers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Master CI on the #360 merge (
85b29151) was red on push and nightly runs, and the PR runs of the same tree were green. This fixes both causes and adds the missing multi-client e2e. v0.37.0 is still untagged; the tag goes on this PR's merge commit once its push run is green. No version bump.#363:
cargo test10× slower on push/schedule, withhost.worker_unavailableRoot cause:
crates/build_version.rs, the build script of cli, daemon, mcp-server, plugin-host and plugin-supervisor, always emittedcargo:rerun-if-changed=.git/packed-refswhen HEAD is a branch ref. Cargo treats a watched path that is missing as always stale.actions/checkouton push and schedule doescheckout -B masterin a fresh clone, so HEAD is a branch ref, the ref is a loose file, and there is nopacked-refs. Every cargo invocation therefore recompiled and relinked those crates and their dependents.What this did to the suite: the suite's in-test
cargo build -p … --bin …calls (registered ininline_cargo_build_registry) each took the build-dir lock and relinkedcode-index-plugin-hostunderneath running tests.worker_unavailablefailures in grammar_cache, plugin_update_cli, plugin_registry_e2e, xaml_package_e2e and language_owner_e2e.stale: missing ".git/packed-refs".Fix: each watch is chosen by what exists.
packed-refs, plus the nearest existing directory above where the loose ref would appear. This keeps #42 (stale--versionhash after a fast-forward) fixed.Test:
crates/test-support/tests/build_script_freshness.rsbuilds a throwaway crate with this build script, in push-shaped and packed-ref git layouts. It asserts that a second build of an unchanged tree compiles nothing, and that a new commit still triggers a rebuild.#362: nightly overhead budgets
These are this PR's full-run numbers, taken with the new
overheadtier.package_leg.shgets a newoverheadtier: one release build of every overhead target, thensync, then the budget assertion.package-ci.ymlgets apackage-overheadjob, nightly and dispatch only. It needs both matrices, has no matrix of its own, and measures one package at a time.ci_path_gating::the_overhead_budgets_are_measured_alone. Putting back the old workflow line turned it red (run).New e2e: a shared project with concurrent MCP clients during startup and first index
crates/mcp-server/tests/shared_project_cold_start_e2e.rs::eight_clients_on_a_cold_project_share_one_daemon_and_converge:project_overview,search_symbolsandsearch_textuntil steady.Lockfile::acquireignores a held lock → red,started: 8 … lost: 0;search_symbolswhile reconciling → red, 8/8 clients fail.testjob and the daemon leg.Verification
Each lane ran targeted tests and its own mutations. I re-ran every lane's tests and one mutation per lane myself, and each mutation went red.
One full local run on
5b1f85fe, all 32 steps green:--document-private-items -D warnings;psr4_vs_builtin, tier 3;precision_gate7/7, phantom 0;package_leg.sh <pkg> fullfor all 11 packages;overheadtier for all 7 languages.baseline.jsonandcost-baseline.jsonare unchanged.Closes #362, #363.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCj
Native Windows CI (ci-windows run 1119) failed the_exit_record_is_never_seen_torn with 1215 reads answering ERROR_FILE_NOT_FOUND (2): while write_atomically's rename replaces the record, the name is briefly absent. read_record read that as "no record", which startup_backoff, classify and exit_announced take as "no backoff" — a product bug on Windows, not only a flake. A NotFound is now waited out only while a writer's temp sibling (`<record>.<pid>.tmp`, any pid) exists beside the record; with none it is re-asked once at once (a rename that completed between the failed open and the look for its temp leaves a record) and a second NotFound is the answer, so the ordinary absent record stays one directory listing, not the 100 ms settle budget. The 5/32 handling is unchanged. The torn-read test now classifies the failing read itself instead of a later re-read: its old "unparsable" bucket counted any non-empty re-read without parsing it, so the 1 "unparsable" in run 1119 was a re-read that SUCCEEDED after the window closed, not torn bytes. Two new tests stage the states on any OS, mutations run on Linux: drop the replace_pending arm -> RED (Err(NotFound)); replace_pending always true -> RED (~100 ms); ignore the name prefix -> RED (~100 ms). The existing test's mutation (plain fs::write) still REDs: {"empty": 301, "unparsable": 106}. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCjRound 1 (
5b1f85fe): ci.yml and package-ci were green. ci-windows run 1119 was red onrestart::tests::the_exit_record_is_never_seen_torn, a pre-existing intermittent failure: this PR didn't touchcrates/daemon, and the test passed on run 1111.It was a real Windows bug, not just a test flake. While
write_atomicallyrenames the temp file over the exit record, Windows can report the record as missing (ERROR_FILE_NOT_FOUND). Commit300a75d9waits out errors 5 and 32 but not this one. A read that fails this way returns "no record", which means "no restart backoff".Fix (
2f21182d,920e7038):<record>.<pid>.tmp) exists. Then the reader retries within the existing 50 × 2 ms budget.an_absent_record_with_a_writer_temp_is_waited_out;an_absent_record_without_a_writer_temp_is_answered_at_once. This one has no wall-clock bound;wall_clock_registryrefused the first version that had one.replace_pendingmade always true; its prefix check dropped; the check removed entirely.Since the full run: only
crates/daemon/src/restart.rschanged. I ran the restart tests (11/11),wall_clock_registry, fmt, workspace clippy, windows-gnu clippy and daemon rustdoc, all green. Only native Windows CI can prove the mechanism, and this round is it.