Nightly: language packages exceed the cold/warm overhead budget against their builtins (1.4–2.1x cold) #362
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#362
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The nightly
package-corpus (<lang>)legs are the only runs that assert the overhead budget:COSI_OVERHEAD_SEMANTIC_ONLY=0onscheduleonly (package-ci.yml), checked incrates/first-party-tests/tests/support/language_overhead.rs. The budget is cold ≤ 1.20 × builtin + 0.50 s and warm ≤ 1.10 ×. PR and push runs report the ratios but don't assert them (ratios_asserted: false), so this stays invisible until the nightly.Semantics are fine:
semantic_failure: nullon every repo. These are budget failures only.Measured
Nightly 1117 (master
85b29151, after #354 lane C made every language package own its walker):typescript failed too. Its numbers are in the job log.
Nightly 1103 (
876b78b5, the previous release) already failed the same way: cs-dapper cold 1.653 / warm 1.103, and js-express cold 1.714. It isn't new. Lane C only put more languages under the budget.Caveat: contention
Run 1117 overlapped with the push runs of the merge: package-ci 1116 and ci.yml 1115, the latter's
cargo testtaking 7302 s. Some cold samples are clearly contended: cs-dapper's first cold package sample was 13.1 s. The medians are still over budget, but the first job is an isolated re-measure (one leg, no parallel runs) before anyone attributes the overhead.Why it matters
The direction is "all parsers become plugins". A user who switches a language to its package currently pays roughly 1.4–2.1× cold-index time against the builtin.
Next
diagnostic_cold_breakdownexists in the row for this.Related: the nightly ci.yml worker flake (filed alongside), #354.