Fix namespace budget inflation and degraded reporting for v0.41.28 #480

Merged
buildagent merged 4 commits from fix/namespace-budget-diagnostics into master 2026-11-02 09:37:17 +01:00
Member

Mixed-language indexes can skip C# namespace resolution because its lookup estimate multiplies namespace calls by imports from unrelated languages. Count the import multiplier from the same admitted language scope skeleton that TypeLookup loads, while retaining global linear load costs, conservative generation counting and every existing work-budget limit. Namespace binding, grant and ambiguity rules stay unchanged.

Doctor now recognizes both legacy _degraded keys and dotted .degraded stage keys. A degraded resolver is reported as a warning instead of beside an OK health label.

PHP's measured warm plugin overhead was 1.117x and 1.153x native in performance runs 2050 and 2051, exceeding the former 1.10x budget. Apply the operator-approved increase to 1.20x for PHP only. C# remains 1.15x and other languages 1.10x. Cold budgets, semantic parity, mixed-load ceilings and CPU admission rules are unchanged. This adjusts the accepted budget; it does not claim a runtime performance improvement. All previous failed receipts are retained.

The initial CI attempt failed before checkout because the pinned Rust image disappeared from the registry. Verify the rebuilt Rust/Cargo 1.99.1 image and matching Clippy against every declared prerequisite, then adopt its immutable index digest in all 41 workflow/baseline pins.

Both product regressions fail before the fixes. Local validation includes 598 indexer tests (four existing ignores), 19 doctor tests, 24 C# resolver integration tests, nine version-site checks, 44 release-gate tests, targeted Clippy with warnings denied, formatting and diff checks. Budget tests exercise the reported PHP failure, language-specific headroom and rejection above each limit. Independent cold self-indexes using v0.41.27 and the candidate each processed 1,433 files and 28,611 symbols without parse errors or resolver-budget degradation; they do not reproduce the retained-generation degradation, which the focused regression demonstrates separately.

Prepare v0.41.28 in this PR so CI and performance qualify one release source head. Release source 44d618de passed all four required CI workflows: Windows 2054, core 2055, packages 2056 and pilots 2057. Core ran 5,349 main tests and 53 selected follow-up tests; Windows ran 5,123 main tests. All 28 budget tests passed locally. Fresh performance run 2058 passed semantic parity and both budgets for all seven pinned languages over five paired rounds, plus mixed-load ceilings. PHP measured 1.097752x against its approved 1.20x limit. An independent check recomputed every median, ratio and margin from the full saved log; no failures. Dependency pins, guest inputs, ABI and schema are unchanged. Refs #445 and #53; their broader acceptance criteria remain open.

Mixed-language indexes can skip C# namespace resolution because its lookup estimate multiplies namespace calls by imports from unrelated languages. Count the import multiplier from the same admitted language scope skeleton that TypeLookup loads, while retaining global linear load costs, conservative generation counting and every existing work-budget limit. Namespace binding, grant and ambiguity rules stay unchanged. Doctor now recognizes both legacy `_degraded` keys and dotted `.degraded` stage keys. A degraded resolver is reported as a warning instead of beside an OK health label. PHP's measured warm plugin overhead was 1.117x and 1.153x native in performance runs 2050 and 2051, exceeding the former 1.10x budget. Apply the operator-approved increase to 1.20x for PHP only. C# remains 1.15x and other languages 1.10x. Cold budgets, semantic parity, mixed-load ceilings and CPU admission rules are unchanged. This adjusts the accepted budget; it does not claim a runtime performance improvement. All previous failed receipts are retained. The initial CI attempt failed before checkout because the pinned Rust image disappeared from the registry. Verify the rebuilt Rust/Cargo 1.99.1 image and matching Clippy against every declared prerequisite, then adopt its immutable index digest in all 41 workflow/baseline pins. Both product regressions fail before the fixes. Local validation includes 598 indexer tests (four existing ignores), 19 doctor tests, 24 C# resolver integration tests, nine version-site checks, 44 release-gate tests, targeted Clippy with warnings denied, formatting and diff checks. Budget tests exercise the reported PHP failure, language-specific headroom and rejection above each limit. Independent cold self-indexes using v0.41.27 and the candidate each processed 1,433 files and 28,611 symbols without parse errors or resolver-budget degradation; they do not reproduce the retained-generation degradation, which the focused regression demonstrates separately. Prepare v0.41.28 in this PR so CI and performance qualify one release source head. Release source `44d618de` passed all four required CI workflows: Windows 2054, core 2055, packages 2056 and pilots 2057. Core ran 5,349 main tests and 53 selected follow-up tests; Windows ran 5,123 main tests. All 28 budget tests passed locally. Fresh performance run [2058](https://git.h-dv.de/h-dv/code-index/actions/runs/2058) passed semantic parity and both budgets for all seven pinned languages over five paired rounds, plus mixed-load ceilings. PHP measured 1.097752x against its approved 1.20x limit. An independent check recomputed every median, ratio and margin from the full saved log; no failures. Dependency pins, guest inputs, ABI and schema are unchanged. Refs #445 and #53; their broader acceptance criteria remain open.
fix: scope namespace lookup budgets and report degraded stages
Some checks failed
CI / cargo clippy (pull_request) Has been skipped
CI / cargo check (MSRV 1.99.1) (pull_request) Has been skipped
CI / cargo check (windows-gnu) (pull_request) Has been skipped
Package CI / package (javascript) (pull_request) Failing after 13s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Has been skipped
CI / CI lane wall-clock headroom (pull_request) Has been skipped
CI / guest crates (fmt, clippy, doc) (pull_request) Has been skipped
Package CI / package (svelte) (pull_request) Failing after 8s
Package CI / package-corpus (csharp) (pull_request) Failing after 11s
Package CI / package (php) (pull_request) Failing after 12s
Package CI / package-corpus (vue) (pull_request) Failing after 8s
Package CI / package-corpus (javascript) (pull_request) Failing after 11s
Package CI / package-corpus (ruby) (pull_request) Failing after 10s
Package CI / package-corpus (timeline) (pull_request) Failing after 8s
CI / OSS corpus (tier 1) (pull_request) Has been skipped
CI / cargo deny (pull_request) Has been skipped
CI / cargo test (pull_request) Has been skipped
CI / cargo doc (intra-doc links) (pull_request) Has been skipped
CI / cargo test (daemon transport) (pull_request) Has been skipped
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been skipped
Package CI / package (vue) (pull_request) Failing after 7s
Package CI / package-corpus (rust) (pull_request) Failing after 6s
Package CI / package-corpus (typescript) (pull_request) Failing after 12s
Package CI / package-corpus (python) (pull_request) Failing after 14s
Package CI / package (ruby) (pull_request) Failing after 12s
Package CI / package (csharp) (pull_request) Failing after 17s
Package CI / package-corpus (xaml) (pull_request) Failing after 12s
Package CI / package-corpus (php) (pull_request) Failing after 15s
Package CI / package (typescript) (pull_request) Failing after 20s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
8dda45849d
ci: repin the verified Rust image after registry replacement
Some checks failed
Package CI / package (vue) (pull_request) Successful in 12m1s
Package CI / package (svelte) (pull_request) Successful in 12m5s
Package CI / package-corpus (svelte) (pull_request) Successful in 42s
Package CI / package (xaml) (pull_request) Successful in 12m9s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Successful in 17m0s
Package CI / package-corpus (timeline) (pull_request) Successful in 44s
Package CI / package (rust) (pull_request) Successful in 12m58s
CI / cargo check (MSRV 1.99.1) (pull_request) Successful in 17m8s
Package CI / package (javascript) (pull_request) Successful in 13m18s
Package CI / package-corpus (vue) (pull_request) Successful in 36s
Package CI / package-corpus (xaml) (pull_request) Successful in 36s
Package CI / package (typescript) (pull_request) Successful in 13m41s
Package CI / package (php) (pull_request) Successful in 14m26s
CI / cargo check (windows-gnu) (pull_request) Successful in 19m45s
Package CI / package (ruby) (pull_request) Successful in 16m17s
Package CI / package (python) (pull_request) Successful in 16m49s
Package CI / package (csharp) (pull_request) Successful in 20m45s
Package CI / package-corpus (php) (pull_request) Successful in 25m53s
CI / cargo test (daemon transport) (pull_request) Has been cancelled
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been cancelled
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Has been cancelled
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been cancelled
Package CI / package-corpus (ruby) (pull_request) Has been cancelled
Package CI / package-corpus (typescript) (pull_request) Has been cancelled
CI / OSS corpus (tier 1) (pull_request) Has been cancelled
Package CI / package-corpus (python) (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
Package CI / package-corpus (javascript) (pull_request) Has been cancelled
Package CI / package-corpus (csharp) (pull_request) Has been cancelled
Package CI / package-corpus (rust) (pull_request) Has been cancelled
a0ff0ae1a0
test: select namespace imports by fixture identity
All checks were successful
Package CI / package (svelte) (pull_request) Successful in 11m33s
Package CI / package (vue) (pull_request) Successful in 11m34s
Package CI / package (xaml) (pull_request) Successful in 12m10s
Package CI / package-corpus (timeline) (pull_request) Successful in 37s
Package CI / package-corpus (svelte) (pull_request) Successful in 47s
Package CI / package (rust) (pull_request) Successful in 12m54s
Package CI / package-corpus (xaml) (pull_request) Successful in 41s
Package CI / package-corpus (vue) (pull_request) Successful in 44s
Package CI / package (javascript) (pull_request) Successful in 13m13s
Package CI / package (php) (pull_request) Successful in 13m54s
Package CI / package (typescript) (pull_request) Successful in 13m50s
CI / cargo check (MSRV 1.99.1) (pull_request) Successful in 18m48s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Successful in 18m53s
Package CI / package (ruby) (pull_request) Successful in 16m27s
Package CI / package (python) (pull_request) Successful in 16m52s
CI / cargo check (windows-gnu) (pull_request) Successful in 20m32s
Package CI / package (csharp) (pull_request) Successful in 21m20s
Package CI / package-corpus (php) (pull_request) Successful in 26m39s
Package CI / package-corpus (rust) (pull_request) Successful in 23m55s
Package CI / package-corpus (javascript) (pull_request) Successful in 35m40s
Package CI / package-corpus (python) (pull_request) Successful in 30m15s
Package CI / package-corpus (csharp) (pull_request) Successful in 38m57s
Package CI / package-corpus (typescript) (pull_request) Successful in 28m32s
Package CI / package-corpus (ruby) (pull_request) Successful in 48m5s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Successful in 58m52s
CI / OSS corpus (tier 1) (pull_request) Successful in 1h45m21s
CI / cargo test (pull_request) Successful in 2h40m9s
CI / cargo test (daemon transport) (pull_request) Successful in 12m29s
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been skipped
1ccb9f5728
test: apply approved PHP warm performance headroom
All checks were successful
Package CI / package (xaml) (pull_request) Successful in 11m35s
Package CI / package (vue) (pull_request) Successful in 11m40s
Package CI / package-corpus (svelte) (pull_request) Successful in 37s
Package CI / package-corpus (timeline) (pull_request) Successful in 38s
Package CI / package-corpus (vue) (pull_request) Successful in 30s
Pilot plugin compatibility / Pilot compatibility result (pull_request) Successful in 1s
Package CI / package (rust) (pull_request) Successful in 12m51s
Package CI / package (javascript) (pull_request) Successful in 12m55s
Package CI / package-corpus (xaml) (pull_request) Successful in 37s
Package CI / package (typescript) (pull_request) Successful in 13m32s
Package CI / package (php) (pull_request) Successful in 13m47s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Successful in 17m46s
Package CI / package (ruby) (pull_request) Successful in 15m59s
CI / cargo check (MSRV 1.99.1) (pull_request) Successful in 18m45s
Package CI / package (python) (pull_request) Successful in 16m30s
CI / cargo check (windows-gnu) (pull_request) Successful in 20m53s
Package CI / package (csharp) (pull_request) Successful in 20m58s
Package CI / package-corpus (php) (pull_request) Successful in 21m24s
Package CI / package-corpus (rust) (pull_request) Successful in 21m7s
Package CI / package-corpus (javascript) (pull_request) Successful in 31m57s
Package CI / package-corpus (python) (pull_request) Successful in 25m4s
Package CI / package-corpus (csharp) (pull_request) Successful in 33m55s
Package CI / package-corpus (typescript) (pull_request) Successful in 23m12s
Package CI / package-corpus (ruby) (pull_request) Successful in 30m57s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Successful in 54m18s
CI / OSS corpus (tier 1) (pull_request) Successful in 1h3m24s
CI / cargo test (pull_request) Successful in 50m53s
CI / cargo test (daemon transport) (pull_request) Successful in 9m7s
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been skipped
44d618de55
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index!480
No description provided.