Fix plugin activation previews and live refusal reporting for v0.41.13 #426

Merged
buildagent merged 2 commits from codex/svelte-activation-followup into master 2026-10-23 12:55:14 +02:00
Member

plugin add could preview zero dirty files for a newly fetched package because its bytes were not installed yet. CLI and MCP now include the verified in-memory candidate in the same grant and duplicate-version selection used for installed packages. The CLI activates the transition it previewed; declining still installs and approves nothing.

Empty outlines and coverage now read refusals from the live contribution projection, so a cleared legacy file verdict cannot turn an extraction refusal into accepted empty facts. Pending/superseded refusals stay outside that projection; unreadable evidence stays unreported. The query retains its cached statement and file-index pin.

Confirmation text distinguishes reserved language domains from native extractors present in the build. It warns when the explicit enabled list excludes a reserved language and uses its public name in the enable command. Approval preserves the operator's list. Prepares core v0.41.13; signed package bytes, schema and SDK/ABI are unchanged.

Validation: workspace all-target Clippy with warnings denied; rustfmt; 15 activation/duplicate-version tests, 9 version-site checks, 14 CLI add tests, 4 displacement/enablement tests, package displacement and daemon verdict tests. MCP add/coverage tests pass on snapshot and daemon transports with their Rust healthy control, including CLI/elicitation parity and a nonzero candidate domain. Fresh parser-free four-binary proofs with published signed packages confirm: Svelte activates and emits App without a second index; a real live embedded refusal with NULL legacy parse_error reaches both tools; JavaScript stays disabled until explicitly enabled, then emits greet.

Fixes #423 and #425. Partially addresses #424 (honest disclosure only): generic-runtime embedded TS/JS extraction in Svelte/Vue remains open. The empty-index activation-policy edge found during validation is tracked in #427; its positive-control gate remains intact.

`plugin add` could preview zero dirty files for a newly fetched package because its bytes were not installed yet. CLI and MCP now include the verified in-memory candidate in the same grant and duplicate-version selection used for installed packages. The CLI activates the transition it previewed; declining still installs and approves nothing. Empty outlines and coverage now read refusals from the live contribution projection, so a cleared legacy file verdict cannot turn an extraction refusal into accepted empty facts. Pending/superseded refusals stay outside that projection; unreadable evidence stays unreported. The query retains its cached statement and file-index pin. Confirmation text distinguishes reserved language domains from native extractors present in the build. It warns when the explicit enabled list excludes a reserved language and uses its public name in the enable command. Approval preserves the operator's list. Prepares core v0.41.13; signed package bytes, schema and SDK/ABI are unchanged. Validation: workspace all-target Clippy with warnings denied; rustfmt; 15 activation/duplicate-version tests, 9 version-site checks, 14 CLI add tests, 4 displacement/enablement tests, package displacement and daemon verdict tests. MCP add/coverage tests pass on snapshot and daemon transports with their Rust healthy control, including CLI/elicitation parity and a nonzero candidate domain. Fresh parser-free four-binary proofs with published signed packages confirm: Svelte activates and emits App without a second index; a real live embedded refusal with NULL legacy parse_error reaches both tools; JavaScript stays disabled until explicitly enabled, then emits greet. Fixes #423 and #425. Partially addresses #424 (honest disclosure only): generic-runtime embedded TS/JS extraction in Svelte/Vue remains open. The empty-index activation-policy edge found during validation is tracked in #427; its positive-control gate remains intact.
Fix prospective plugin activation and live refusal disclosure
Some checks failed
Package CI / package-corpus (python) (pull_request) Successful in 28s
Package CI / package (javascript) (pull_request) Successful in 36s
Package CI / package (rust) (pull_request) Successful in 40s
Package CI / package-corpus (svelte) (pull_request) Successful in 36s
Package CI / package (php) (pull_request) Successful in 45s
Package CI / package-corpus (csharp) (pull_request) Successful in 46s
Package CI / package-corpus (rust) (pull_request) Successful in 46s
Package CI / package-corpus (xaml) (pull_request) Successful in 43s
Package CI / package-corpus (typescript) (pull_request) Successful in 46s
Package CI / package-corpus (ruby) (pull_request) Successful in 56s
Package CI / package-corpus (timeline) (pull_request) Successful in 52s
Package CI / package-corpus (vue) (pull_request) Successful in 54s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
CI / guest crates (fmt, clippy, doc) (pull_request) Successful in 1m2s
Pilot plugin compatibility / Fetch the pinned runtime once (pull_request) Successful in 1m45s
CI / CI lane wall-clock headroom (pull_request) Successful in 1m34s
Pilot plugin compatibility / Pilot compatibility (timeline) (pull_request) Successful in 1m3s
Pilot plugin compatibility / Pilot compatibility (csharp) (pull_request) Successful in 1m8s
Pilot plugin compatibility / Pilot compatibility result (pull_request) Successful in 0s
CI / cargo doc (intra-doc links) (pull_request) Successful in 4m58s
CI / cargo clippy (pull_request) Successful in 5m53s
CI / cargo test (pull_request) Has been cancelled
CI / cargo test (daemon transport) (pull_request) Has been cancelled
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been cancelled
CI / cargo check (windows-gnu) (pull_request) Has been cancelled
CI / cargo deny (pull_request) Has been cancelled
CI / OSS corpus (tier 1) (pull_request) Has been cancelled
CI / cargo check (MSRV 1.98) (pull_request) Has been cancelled
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Has been cancelled
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Has been cancelled
643c81afca
Use public language ids in plugin enablement warnings
All checks were successful
Package CI / package (timeline) (push) Successful in 12s
Package CI / package (vue) (push) Successful in 12s
Package CI / package (xaml) (push) Successful in 10s
Package CI / package (typescript) (push) Successful in 16s
Pilot plugin compatibility / Fetch the pinned runtime once (push) Successful in 1m22s
Package CI / package-corpus (php) (push) Successful in 20s
Package CI / package-corpus (csharp) (push) Successful in 27s
Package CI / package-corpus (ruby) (push) Successful in 19s
Package CI / package-corpus (python) (push) Successful in 24s
Package CI / package-corpus (javascript) (push) Successful in 30s
Package CI / package-corpus (rust) (push) Successful in 22s
Package CI / package-corpus (svelte) (push) Successful in 19s
Package CI / package-corpus (timeline) (push) Successful in 21s
Package CI / package-corpus (typescript) (push) Successful in 21s
Package CI / package-corpus (vue) (push) Successful in 20s
Package CI / package-corpus (xaml) (push) Successful in 23s
Package CI / package overhead budgets (nightly, one package at a time) (push) Has been skipped
Pilot plugin compatibility / Pilot compatibility (csharp) (push) Successful in 1m6s
Pilot plugin compatibility / Pilot compatibility (timeline) (push) Successful in 1m10s
Pilot plugin compatibility / Pilot compatibility result (push) Successful in 1s
Release Build / Generate Version (push) Successful in 38s
Release Build / Required CI green (push) Successful in 1m50s
Release Build / Build windows-x86_64 (push) Successful in 21m16s
Release Build / Build linux-aarch64 (push) Successful in 1h15m21s
Release Build / Build linux-x86_64 (push) Successful in 1h31m51s
Release Build / Build linux-x86_64-musl (push) Successful in 1h33m45s
Release Build / Assemble the release archives (push) Successful in 4m51s
Release Build / Windows archive smoke (msvc) (push) Successful in 39s
Release Build / Create Forgejo Release (push) Successful in 6m34s
Release Build / Seed the package channel (push) Successful in 3m8s
36b492c91a
Author
Member

The independent signed-package replay caught a warning-name defect before merge: StoredPackage carries wire IDs, whereas the public enable command takes reserved row IDs. The follow-up commit maps through langid::row_lang and limits enablement warnings to languages the setting actually controls. The regression now checks that explicitly enabling ruby removes the warning for the same signed fixture.

Both published-package proofs pass with the parser-free candidate: plain Svelte produces the App module immediately after add (no second index); JavaScript preserves its explicit disabled state on approval, prints the accepted public enable command, and produces greet after explicit enablement. A separate genuinely empty-index policy case is recorded as #427; the existing positive-control gate remains intact. Clippy for the correction passes. Merge must qualify the new PR head.

The independent signed-package replay caught a warning-name defect before merge: StoredPackage carries wire IDs, whereas the public enable command takes reserved row IDs. The follow-up commit maps through langid::row_lang and limits enablement warnings to languages the setting actually controls. The regression now checks that explicitly enabling `ruby` removes the warning for the same signed fixture. Both published-package proofs pass with the parser-free candidate: plain Svelte produces the App module immediately after add (no second index); JavaScript preserves its explicit disabled state on approval, prints the accepted public enable command, and produces greet after explicit enablement. A separate genuinely empty-index policy case is recorded as #427; the existing positive-control gate remains intact. Clippy for the correction passes. Merge must qualify the new PR head.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index!426
No description provided.