fix(indexer): let watcher edits interrupt forced resolution #403

Merged
buildagent merged 2 commits from codex/forgejo-issues-top-down into master 2026-10-21 11:28:06 +02:00
Member

Watcher edits could wait behind a complete resolve after eight unresolved flushes: the starvation guard deliberately stopped arming preemption. Reuse the existing durable resolver queue at that boundary, commit one bounded reference batch, then yield to waiting writer work.

Carry a matching checkpoint across body-only edits, including requeued incoming calls to reminted symbol IDs. Outline, classification, delegated-pool, project-alias and external snapshot changes still invalidate it. Cancellation stays immediate. Add one debug record per committed watcher batch and resolve scheduling records.

Fixes #390's reproduced forced-pass preemption hole. This bounds forced work to a reference batch, not a wall-clock deadline; the original zammad field report still needs confirmation. No schema, ABI or plugin artifact changes. Bump the core patch version to 0.41.5; all external dependency lock records are unchanged.

Validation:

  • Full indexer library: 542 passed, four ignored.
  • Durable resolution: 11 passed; progress/cancellation controls: 10 passed.
  • Controlled forced-pass regression fails before the fix; removing incoming-call requeue makes its regression fail.
  • Ref-kind and bounding-site architecture audits: 31 passed.
  • Workspace formatting, Clippy with warnings denied, private-item documentation with warnings denied, and Windows-GNU indexer check passed.
  • Daemon watcher/snapshot/generation: 27 passed. Candidate C# (six fixtures, including delete/restore semantic controls) and Timeline (five fixtures) compatibility passed.
  • Same-daemon C# alias add/remove through the watcher passed without explicit reindex.
  • Catalog validation (8), release gates (43), version-site registry (9), and MCP catalog end-to-end checks (7) passed after aligning the source catalog/install examples with 0.41.5.
  • Parser-free production build (--no-default-features, separate CLI/daemon/MCP and worker invocations): fresh adoption of seven language packages and refusal of all seven removed builtin owners passed with published bundles; no project config was created.
  • Final head bf4e1023a46e8345d2ec500c2b8a9c571882ad6e passed all four workflows: Windows, core and corpus, packages, and pilots. Core: 4,998 main tests and 37 serial timing tests passed; native Windows: 4,781 main tests and 27 serial timing tests passed.

Published as stable/latest v0.41.5; release workflow 6230 passed all ten jobs. Independent published verification passed: all four archive hashes; all seven bundled package/signature pairs unchanged in each archive; all eleven signed-channel plugin records unchanged and all 30 package versions retained; seven checksum sidecars and installer Git blob identities; fresh seven-language adoption, removed builtin refusal, and live C# alias add/remove through the same daemon. The previous and current released runtimes both verify the new signed catalog/channel with compiled-in anchors alone.

#401 remains open: PR #402 fixed a reproduced stale-PID cleanup defect, but did not establish the original initialize EOF's cause.

Watcher edits could wait behind a complete resolve after eight unresolved flushes: the starvation guard deliberately stopped arming preemption. Reuse the existing durable resolver queue at that boundary, commit one bounded reference batch, then yield to waiting writer work. Carry a matching checkpoint across body-only edits, including requeued incoming calls to reminted symbol IDs. Outline, classification, delegated-pool, project-alias and external snapshot changes still invalidate it. Cancellation stays immediate. Add one debug record per committed watcher batch and resolve scheduling records. Fixes #390's reproduced forced-pass preemption hole. This bounds forced work to a reference batch, not a wall-clock deadline; the original zammad field report still needs confirmation. No schema, ABI or plugin artifact changes. Bump the core patch version to 0.41.5; all external dependency lock records are unchanged. Validation: - Full indexer library: 542 passed, four ignored. - Durable resolution: 11 passed; progress/cancellation controls: 10 passed. - Controlled forced-pass regression fails before the fix; removing incoming-call requeue makes its regression fail. - Ref-kind and bounding-site architecture audits: 31 passed. - Workspace formatting, Clippy with warnings denied, private-item documentation with warnings denied, and Windows-GNU indexer check passed. - Daemon watcher/snapshot/generation: 27 passed. Candidate C# (six fixtures, including delete/restore semantic controls) and Timeline (five fixtures) compatibility passed. - Same-daemon C# alias add/remove through the watcher passed without explicit reindex. - Catalog validation (8), release gates (43), version-site registry (9), and MCP catalog end-to-end checks (7) passed after aligning the source catalog/install examples with 0.41.5. - Parser-free production build (`--no-default-features`, separate CLI/daemon/MCP and worker invocations): fresh adoption of seven language packages and refusal of all seven removed builtin owners passed with published bundles; no project config was created. - Final head `bf4e1023a46e8345d2ec500c2b8a9c571882ad6e` passed all four workflows: [Windows](https://git.h-dv.de/h-dv/code-index/actions/runs/1395), [core and corpus](https://git.h-dv.de/h-dv/code-index/actions/runs/1396), [packages](https://git.h-dv.de/h-dv/code-index/actions/runs/1397), and [pilots](https://git.h-dv.de/h-dv/code-index/actions/runs/1398). Core: 4,998 main tests and 37 serial timing tests passed; native Windows: 4,781 main tests and 27 serial timing tests passed. Published as stable/latest [v0.41.5](https://git.h-dv.de/h-dv/code-index/releases/tag/v0.41.5); release workflow 6230 passed all ten jobs. Independent published verification passed: all four archive hashes; all seven bundled package/signature pairs unchanged in each archive; all eleven signed-channel plugin records unchanged and all 30 package versions retained; seven checksum sidecars and installer Git blob identities; fresh seven-language adoption, removed builtin refusal, and live C# alias add/remove through the same daemon. The previous and current released runtimes both verify the new signed catalog/channel with compiled-in anchors alone. #401 remains open: PR #402 fixed a reproduced stale-PID cleanup defect, but did not establish the original initialize EOF's cause.
fix(indexer): yield forced resolves after durable progress (#390)
Some checks failed
Package CI / package (vue) (pull_request) Successful in 33s
Package CI / package (timeline) (pull_request) Successful in 42s
Package CI / package-corpus (timeline) (pull_request) Successful in 36s
Package CI / package-corpus (ruby) (pull_request) Successful in 37s
Package CI / package-corpus (javascript) (pull_request) Successful in 46s
Package CI / package (svelte) (pull_request) Successful in 51s
Package CI / package-corpus (svelte) (pull_request) Successful in 48s
Package CI / package-corpus (vue) (pull_request) Successful in 40s
Package CI / package-corpus (python) (pull_request) Successful in 54s
Package CI / package-corpus (xaml) (pull_request) Successful in 44s
Package CI / package (xaml) (pull_request) Successful in 1m0s
Package CI / package-corpus (typescript) (pull_request) Successful in 59s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
CI / CI lane wall-clock headroom (pull_request) Successful in 1m19s
CI / guest crates (fmt, clippy, doc) (pull_request) Successful in 1m9s
Pilot plugin compatibility / Fetch the pinned runtime once (pull_request) Successful in 1m34s
Pilot plugin compatibility / Pilot compatibility (csharp) (pull_request) Successful in 1m0s
Pilot plugin compatibility / Pilot compatibility (timeline) (pull_request) Successful in 1m0s
Pilot plugin compatibility / Pilot compatibility result (pull_request) Successful in 1s
CI / cargo clippy (pull_request) Successful in 4m49s
CI / cargo doc (intra-doc links) (pull_request) Successful in 5m0s
CI / cargo check (MSRV 1.98) (pull_request) Successful in 6m29s
CI / cargo deny (pull_request) Successful in 6m28s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Successful in 6m38s
CI / cargo check (windows-gnu) (pull_request) Successful in 7m9s
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Has been cancelled
CI / cargo test (daemon transport) (pull_request) Has been cancelled
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been cancelled
CI / cargo test (pull_request) Has been cancelled
CI / OSS corpus (tier 1) (pull_request) Has been cancelled
7832d90aae
fix(release): align catalog and install examples with 0.41.5
All checks were successful
Package CI / package-corpus (rust) (pull_request) Successful in 54s
Package CI / package-corpus (xaml) (pull_request) Successful in 51s
Package CI / package overhead budgets (nightly, one package at a time) (pull_request) Has been skipped
CI / guest crates (fmt, clippy, doc) (pull_request) Successful in 1m9s
CI / CI lane wall-clock headroom (pull_request) Successful in 1m24s
Pilot plugin compatibility / Fetch the pinned runtime once (pull_request) Successful in 1m46s
Pilot plugin compatibility / Pilot compatibility (csharp) (pull_request) Successful in 57s
Pilot plugin compatibility / Pilot compatibility (timeline) (pull_request) Successful in 1m12s
Pilot plugin compatibility / Pilot compatibility result (pull_request) Successful in 1s
CI / cargo doc (intra-doc links) (pull_request) Successful in 4m57s
CI / cargo clippy (pull_request) Successful in 5m15s
CI / cargo deny (pull_request) Successful in 6m23s
CI / cargo check (MSRV 1.98) (pull_request) Successful in 6m39s
CI / cargo test (abi, 32-bit + wasm32) (pull_request) Successful in 6m31s
CI / cargo check (windows-gnu) (pull_request) Successful in 7m12s
CI / cargo test (pull_request) Successful in 21m24s
CI / OSS corpus (tier 1) (pull_request) Successful in 31m41s
CI / cargo test (daemon transport) (pull_request) Successful in 9m14s
CI / Plugin path cost + pool throughput (nightly) (pull_request) Has been skipped
CI (Windows) / fmt + clippy + build + test (windows) (pull_request) Successful in 39m47s
Release Build / Generate Version (push) Successful in 20s
Release Build / Required CI green (push) Successful in 1m15s
Release Build / Build linux-aarch64 (push) Successful in 11m49s
Release Build / Build linux-x86_64 (push) Successful in 14m1s
Release Build / Build linux-x86_64-musl (push) Successful in 14m16s
Release Build / Build windows-x86_64 (push) Successful in 20m1s
Release Build / Assemble the release archives (push) Successful in 3m46s
Release Build / Windows archive smoke (msvc) (push) Successful in 27s
Release Build / Create Forgejo Release (push) Successful in 5m26s
Release Build / Seed the package channel (push) Successful in 2m33s
bf4e1023a4
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index!403
No description provided.