No reviewers
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index!373
Loading…
Reference in a new issue
No description provided.
Delete branch "train-0372"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes what dogfooding v0.37.1 on this repository found, and the red nightly CI. The version is bumped in this PR with
version_bump.sh. Schema 81 → 82 (m0082: one full resolve on upgrade, no re-parse). Packages are unchanged.#367: Rust calls through a workspace module alias resolve (lane E)
temp.qual_groups(crates/indexer/src/index.rs) only admitted modules spelled./crate::/self::/super::.use code_index_core::lang_profile as lp; lp::f()was never expanded, although the fully spelled path resolved.rust_use_head_is_workspace, the checkfollow_own_importsalready uses. The same-file join, the "alias declared twice binds nothing" gate and whole-qualifier matching are unchanged. The lookup reads Rust imports only, so it costs nothing in other languages (fullscan_stepis identical to master).parsed=0and equals a fresh index bind for bind.tier1q_alias, all hand-checked correct.precision_gate7/7, phantom 0, with a new Rust alias probe and decoy.tier3-baseline.json: rust-analyzer only, exactly the +50.host-package-lifecycle.json: schema condition only, 0 counts moved.ruby-package-cost.json: schema 82.vm_step+0.006%, inside the record's 0.02% determinism. Measured on one box: master 27,933,085 / 27,932,224 against this binary 27,935,458 / 27,934,443.baseline.jsonandcost-baseline.jsonunchanged.#368:
evidence_incompleteonly from partial files that could reference the target (lane P)downgrade_absence_verdict) now counts a partial file only if its rows share the target's language (filter_admits), an active bridge leads into it, or its languages are unknown.EMBEDDED_ROUTES). There is no path heuristic: a partial Rust file undertests/still downgrades a Rust target.partial_sources_in_scope(a count) sits beside the unchangedpartial_sources_in_index. Theresolution_gapscensus states its scope and givesin_requested_scopewhen the call is filtered. The agent-task token cost is exactly master's (12,495).Replies that state what they did not measure (lane D)
defining_file_verifiedis set where the defining file is actually verified, for bothcheck_renameandsafe_delete. A full window gets a by-path pass in both tools.changed_symbols/review_diff: a page with files remaining shipsomitted_symbols_unmeasured: "paged_files_not_counted"instead of an unmeasured0.spellings_present: when it is capped, it says "the N nearest of the M".search_text: a bareAND/OR/NOT/NEARis an operator only when single terms strictly alternate.CREATE TABLE IF NOT EXISTS twas silently answered as a boolean (339 files); it is now one literal phrase (1).(a OR b) cstill works. Behaviour change: an unparenthesisedalpha OR beta gammais now a literal phrase.Nightly CI (red since about 2026-10-06; fixed here)
bench_generation_gc(lane G): the bench promoted a hand-written, empty generation. 0.37.1's correctSwitch::owedmark then re-extracted the files and emptied it, and the vacuity guard fired. The bench now builds the mirror generation for real. The guard is just as strict, and it still times 502/12,502 and 100,002/2,500,002 rows.language_package_overhead(lane N): it compared native output against a binary pinned at312a242e(2026-10-03). Every difference maps to an intended, blessed change: #309, #326, #335, #336, #337, #348, and the migration span fixes. Nothing was unexplained.corpus_ratchet/corpus_stage; dropping a CLI builtin turns this check red.Verification (I re-ran each lane's tests and at least one mutation myself; all RED, restored by md5)
9a89ac6a:--document-private-items -D warnings;psr4_vs_builtin, tier 3,corpus_scale, mixed-load,overview_scale_2m;precision_gate7/7, phantom 0;package_leg.sh <pkg> fulland all 7overheadlegs. The js leg was re-measured quiet after a contended run at load 10.plugin-path-costjob: phase2 acceptance (7 languages, signed install, MCP, watch, restart),language_package_overhead,plugin_path_cost,package_pool,grammar_ab,claim_domain_scale,bench_promotion_lock,bench_generation_gc,bench_read_epoch, the 235-project resolver.grammar-rebuild(no grammar changed; it needs CI's clang-18 toolchain).find_callers(nearest_spellings)returns 4/4 resolved, including bothlp::calls inserver.rs. The keyword phrase is matched literally.🤖 Generated with Claude Code
https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCj
safe_delete / check_rename downgraded every verdict to `evidence_incomplete` whenever ANY file in the index was a partial source, so six intentionally broken Svelte/XAML package fixtures made every Rust verdict in this repo read "evidence incomplete". One shared rule now decides (`partial_source_could_reference`, counted by `partial_sources_relevant_to`): a partial file is in scope of a target when its rows share the target's language (spelling-equivalent via the shared lang_profile filter rule, so `ruby` == `de.h-dv.ruby/ruby`), when an active granted bridge leads from one of its languages into the target's, or when its languages / the bridges / the target are unknown (fail closed). No path or test-role heuristic: a partial Rust file under tests/ still downgrades. - daemon: `PartialSource.languages` = files.lang + extraction_components.lang of every live contribution (a Svelte script region counts as typescript); `PartialSources.bridges` read through bridges::load_active. Both additive, `None` from an older daemon = unknown = in scope. - mcp: `evidence_gaps.partial_sources_in_scope {count, target_languages}` on safe_delete/check_rename beside the unchanged project-wide `partial_sources_in_index`, plus a semantics clause; the downgrade fires on the scoped count. - resolution_gaps: `partial_source_census` keeps listing everything, gains a `scope` statement and `in_requested_scope` computed with the call's own project / exclude_tests (is_test_path, the rule that stamps test-role refs) / lang (filter_admits over the file's languages) / path_glob (SQLite GLOB). - safe_delete/check_rename descriptions reworded shorter ("an in-scope file's extractor"), startup payload shrinks. Tests: partial_source_scope_e2e (both legs) + unit tests; mutations run and recorded in the test docs. harness_settle_barrier 58 -> 59. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCj`use code_index_core::lang_profile as lp;` then `lp::nearest_spellings()` stayed unresolved although `imports` held {module, alias: "lp"}: the I051 alias expansion into `temp.qual_groups` admitted only modules whose string starts with `.`/`crate::`/`self::`/`super::`, so a path headed by a SIBLING workspace crate never entered it. The fully spelled path already anchored (tier 1Q pass 1). One rule, reusing clause (c) of `follow_own_imports`: an aliased module whose head passes `rust_use_head_is_workspace` over the `file_anch` package-tail vocabulary, in a language whose own-import proof is Rust's module-file rule, is admitted too (`temp.alias_ws_modules`, read as one indexed IN). Same-file join, ambiguity gate and whole-qualifier equality are unchanged. Measured bind for bind against the master binary, joined on (path, line, col, kind, occurrence): rust-analyzer +50 (all tier1q_alias, all hand- checked right), this repository +68 (40 sampled, seed 367, all right; the seven lp:: calls in server.rs among them), the other eight pinned repositories identical; 0 lost, 0 retargeted. corpus_ratchet and corpus_cost green; tier3-baseline.json moves for rust-analyzer (rule.tier1q_alias +50) and is NOT blessed here. No migration: existing indexes gain these binds only when a Full resolve runs. A re-heal needs a schema bump, which moves the schema condition of the recorded package baselines; left to the operator. Tests: resolution_provenance (positive, decoy pair, rebound, other- file, external-crate negatives; mutations run), precision_gate Rust probe + same-stem decoy (population 31/20/71/476 -> 33/21/74/483), pool_capability_registry stance for the new temp relation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCjPlain text holding an upper-case keyword between multi-word runs ("CREATE TABLE IF NOT EXISTS generation_packages") tripped has_fts5_operator and was passed to FTS5 as an expression: loose words around a NOT, a different and far broader query (339 files vs 1), with the spanned word IF reported dark. A bare boolean is now an operator only when single terms and operators strictly alternate (foo AND bar, a OR b OR c); anything else is phrase-wrapped, as the quoted form already was. whole_word_e2e's bare-expression case moves to the alternating form, and its multi-word form becomes a literal control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDDBdWU4yThi8Zi51E6FCj