Layering: core depends on the signing crate via registry.rs, and get_dependencies emits no mod/crate edges so layering cannot be measured #526
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#526
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Two layering problems. The second makes the first, and #32, impossible to verify with our own tools.
coreis not a foundation crate.crates/core/src/registry.rs(1,268 lines, the Forgejo release catalog) is whycode-index-coredepends oncode-index-package, the signing crate (crates/core/Cargo.toml:27,registry.rs:43). Its only consumers arecliandmcp-server. Separately,mcp-serverdepends on the wholedaemoncrate just to getIndexAccessandLocalIndex.get_dependenciescannot answer a layering question.get_dependencies(crates/indexer/src/lib.rs)returned only 35pub usere-exports. It returned nomodedges and no crate-level (Cargo) edges, so the reviewer had to readCargo.tomlfrom the shell. #28 (SCC/layering analysis) needs exactly these edges.Proposal
registry.rsintopackage, or a newdistributioncrate, socoredepends on nothing internal.IndexAccessand the wire rows out ofdaemoninto a smallaccesscrate thatmcp-server,clianddaemonshare.moddeclarations as import edges, and Cargo[dependencies](plus their equivalents in the other ecosystems:package.json,.csproj,composer.json,pyproject,Gemfile) as crate/package-level edges.get_dependenciesand #28 can then report layering.Acceptance
cargo tree -p code-index-coreshows no internal crates.get_dependencieson this repository lists the crate graph, and that graph matchescargo metadata.Related: #32, #28. Found by an automated architecture review (2026-11-09); the Cargo edge was verified by hand.
Filed from a five-agent review of master @
e3ec6ead(bloat, robustness, agent usefulness, docs, architecture). Every finding was spot-checked in the main session before filing.Consolidated into #543 and #517 during the 2026-11-09 triage. The remaining scope of this issue is tracked there as a checklist item; this report stays as the detailed evidence.