feat: detect_cycles + check_layering — file/crate SCCs and cycle-aware edit checks #28

New issue

Open

opened 2026-07-20 22:38:26 +02:00 by buildagent · 1 comment

buildagent commented

2026-07-20 22:38:26 +02:00

Member

Rank 7 of the 2026-07-20 index-data brainstorm (_prdoc/records/brainstorm-2026-07-20-index-data-catalog.md).

What: Tarjan SCCs over file-level edges (which files cannot be edited independently) plus a crate-layering conformance mode checked against Cargo.toml workspace deps — an "architectural conscience" an agent consults before adding an import.

Why: 5 real file-level 2-cycles exist right now: cli/main.rs↔link.rs, cli/main.rs↔doctor.rs, indexer/db.rs↔migrations.rs, daemon/access.rs↔local_index.rs, plus a ruby fixture cycle (proving cross-language detection). Crate layering is perfectly clean (0 violations across 14 boundaries) — so the conformance mode ships as a cheap enforceable CI invariant. Boundary surfaces are strikingly narrow (indexer→plugins crosses through exactly ONE symbol, all_plugins).

Cost: small — Tarjan on ~109 file nodes at query time + Cargo.toml parse; no new data.

Rank 7 of the 2026-07-20 index-data brainstorm (`_prdoc/records/brainstorm-2026-07-20-index-data-catalog.md`). **What**: Tarjan SCCs over file-level edges (which files cannot be edited independently) plus a crate-layering conformance mode checked against Cargo.toml workspace deps — an "architectural conscience" an agent consults before adding an import. **Why**: 5 real file-level 2-cycles exist right now: `cli/main.rs↔link.rs`, `cli/main.rs↔doctor.rs`, `indexer/db.rs↔migrations.rs`, `daemon/access.rs↔local_index.rs`, plus a ruby fixture cycle (proving cross-language detection). Crate layering is perfectly clean (0 violations across 14 boundaries) — so the conformance mode ships as a cheap enforceable CI invariant. Boundary surfaces are strikingly narrow (indexer→plugins crosses through exactly ONE symbol, `all_plugins`). **Cost**: small — Tarjan on ~109 file nodes at query time + Cargo.toml parse; no new data.

buildagent referenced this issue

2026-07-20 22:38:58 +02:00

refactor: resolve 4 file-level dependency 2-cycles (architecture backlog) #32

buildagent referenced this issue

2026-07-20 22:45:36 +02:00

feat: semantic_diff / review_diff — explain structural risk, not changed lines #34

buildagent referenced this issue

2026-07-20 22:45:36 +02:00

feat: context_pack — task-specific, evidence-linked context under a token budget #35

buildagent commented

2026-07-21 14:26:47 +02:00

Author

Member

Triage: P3 — useful analyzer, not the next milestone

Keep open, but schedule after stable handles (#37) and context_pack (#35). Implement file-level SCC detection first; layering conformance should be a separate mode with explicit configuration rather than inferred architectural policy.

Design it as a reusable analyzer consumed by review_diff (#34) and context_pack, not necessarily another frequently invoked top-level tool. Findings must distinguish newly introduced cycles from pre-existing cycles and exclude/label fixtures and generated code.

### Triage: P3 — useful analyzer, not the next milestone Keep open, but schedule after stable handles (#37) and `context_pack` (#35). Implement file-level SCC detection first; layering conformance should be a separate mode with explicit configuration rather than inferred architectural policy. Design it as a reusable analyzer consumed by `review_diff` (#34) and `context_pack`, not necessarily another frequently invoked top-level tool. Findings must distinguish newly introduced cycles from pre-existing cycles and exclude/label fixtures and generated code.

buildagent referenced this issue

2026-07-21 14:26:47 +02:00

feat: context_pack — task-specific, evidence-linked context under a token budget #35

buildagent referenced this issue

2026-07-21 14:26:51 +02:00

refactor: resolve 4 file-level dependency 2-cycles (architecture backlog) #32

buildagent added the

correctness

label

2026-07-21 14:27:23 +02:00

buildagent referenced this issue

2026-07-21 15:43:30 +02:00