fix(xaml): capture keyboard handlers in package 0.3.2 #451
No reviewers
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index!451
Loading…
Reference in a new issue
No description provided.
Delete branch "codex/xaml-event-reference-coverage"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
XAML0.3.1 emitted Click handlers but no keyboard-handler references, so a real root KeyDown use looked absent. Package0.3.2 now captures KeyDown, KeyUp, PreviewKeyDown and PreviewKeyUp on root/child elements and in attached owner syntax. Exact-name or dot-owner matching rejects ordinary properties such as NotKeyDown and KeyDownExtra. Fixes #450; focused follow-up to #448.
The package-owned Wasm extractor, version, fixture, provenance, digests and catalog row are updated. The operator guide uses the matching0.3.2 archive/digest. Existing Click/name/class/binding/resource rules and extraction ceilings remain in place; no host runtime or bridge authority changes.
Validation: the new production-conformance fixture was RED with5 missing refs before the extractor fix and GREEN after, including property decoys. A signed candidate upgraded an existing DB on the actual published0.41.17 core: root/child KeyDown and Click resolve only to the paired private code-behind handlers despite a same-name base-class handler. This passes with published C#0.1.7 and candidate0.1.8, and MCP find_references reports the root use.
Local package release-tier suites pass, including WAT reproducibility, all5 runtime fixtures, paired bridge grants, package/registry/release-script gates. The release guard initially caught the stale guide pin; after correcting it, all43 release_gate tests pass. Strict affected-target Clippy, workspace fmt and diff checks pass. Candidate canonical digest: sha256:491eebd1910a03ca3a5745f55863d2ff49d6796f358a571f330b8bd8abc91abe.
Release independently as pkg/de.h-dv.xaml/v0.3.2 after normal CI/merge. The x:Name/code-behind use channel, C# method groups and other #448 findings remain separate work.
buildagent referenced this pull request2026-10-24 18:28:40 +02:00
Windows, Linux workspace/corpus, all package and pilot checks passed. The final daemon transport run 6601/job48918 reported
sustained_mixed_mcp_transport_remains_healthyfailed; its remaining context-pack sweeps are still running, so the harness has not printed the panic details yet. Merge/publication is held until that is diagnosed and the required gate is green.Controls on the combined core source: the exact soak passes locally in 8.25s; a bounded one-CPU/eight-competing-worker probe also passes (27.325s total, no protocol/tool/request-timeout error). These controls do not replace the failing CI gate, and neither the per-request timeout nor aggregate threshold has changed. The full XAML package release tier on the combined source is green (
/tmp/cosi-455-combined-xaml-release.log).The captured failure is the aggregate-throughput assertion, not a failed request: all300 mixed requests completed, then mcp_smoke.rs:6275 rejected their total45.847544073s against30s. The existing harness's per-response30s deadline and all response/protocol/tool assertions passed. Root cause and correction are tracked in #456.
PR #455 already contains this exact XAML package source and now also addresses that CI defect, retaining every correctness assertion and response deadline. Its corrected combined head will receive full normal CI and supply the merge/release qualification. The stale red #451 tree will not be force-merged or treated as green. Both package artifacts remain byte-identical to #451, independently graded on the combined source.
Superseded by merged PR #455. The exact XAML0.3.2 source/artifact from this branch is a merged ancestor of qualified head
b87450ffand master merge5fcc3509. All normal Windows/core/package/pilot workflows6633–6636 passed on the corrected combined tree; its tree equals the actual merge tree. The old daemon-transport failure in this PR was investigated and corrected as #456, not waived or force-merged.The annotated pkg/de.h-dv.xaml/v0.3.2 tag is now on the qualified master merge and its independent package publication workflow is running. Closing this duplicate PR; no XAML changes are omitted. #450 is fixed through #455. Official signed-asset/channel verification follows publication.
Publication is now complete: XAML0.3.2 release. The official signature, canonical digest, signed catalogs and actual core0.41.17 upgrade have been independently verified; see #450 for the receipt. This PR stays closed as superseded by normally merged #455.
Pull request closed