Restart after a killed promotion chose scope=Skipped while m0007 pending work existed; owed full resolve deferred ~20 min to later incremental passes #343
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#343
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This came up during #334 (zammad-dev, 0.34.0). The daemon was killed during the post-promotion resolve. The restarted daemon (pid 813834) then logged at 14:40:48:
index stage complete: reference resolution elapsed_ms=0 resolved=0 invalidated=0 scope=SkippedSo the owed Full resolve did not run at startup. Later incremental passes caught it up; the largest, at 15:00:40, had
tier1_unique=12233 …. Final counts match the pre-upgrade state, so nothing was lost. For about 20 minutes, though, readers got floors with no stated cause.The debug lane's reproduction did NOT show this: its restart on a killed DB ran the owed Full resolve in 55 s. Possible differences:
resolve_owed/ pending-table state at kill time;profile.(fields) 17 of 18refusal (#339) changing the activation comparison.To do
Skippedwith m0007 pending rows present.index_statenaming pending resolution).Related: #334, #339, #341.
Not reproduced, so I'm keeping this open.
What shipped in v0.35.0: a regression test,
first_party_influence, pins the behaviour. A restart after a killed promotion runs the Full resolve it still owes. If that resolve is skipped whenever nothing was parsed, the test fails with the field's symptom.Why the field log is still unexplained. Every code path that empties the pending tables also resolves them. So the field's
scope=Skippedmeans those tables were already empty when the restart happened. Two possible reasons:--no-daemonMCP process;What would settle it: the field database as it was at kill time, or the restart's full daemon.log.
Triage 2026-11-09: OBSOLETE: since
71afdb73(#53) publications switch and resolve atomically (promotion.rs:475), and owed work is disclosed throughresolution_pendingoverlays (#375). The restart regression is pinned infirst_party_influence.rs. The mechanism the report described no longer exists.