A package profile stored by an older host is unreadable ("profile.(fields) = 17 of 18") after the host adds a trait; the builtin silently stands and the next pass costs a spurious full re-resolve #339
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#339
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This was found while working on #334, from zammad-dev's daemon.log and confirmed in the reproduction.
Observed
After upgrading from 0.33.1 to 0.34.0, both the migration and the promotion log:
declared profile not readable by this build; the builtin answer stands lang="de.h-dv.ruby/ruby" refusal=profile.(fields) = "17 of 18"Cause
lexical_constant_lookuptrait (#326), and its decoder requires exactly 18 fields.Consequences
the capability/bridge grant moved…withcapabilities_moved=false bridges_moved=false). That costs one unneeded Full re-resolve, about 1 min on Zammad.Proposed fix
extendsprofile's defaults, so a profile written by an older host stays readable.Released in v0.35.0 (https://git.h-dv.de/h-dv/code-index/releases/tag/v0.35.0), via PR #351.
A package profile stored by an older host now decodes over its
extendsprofile instead of being refused.When a newer host re-records it, the profiles are compared decoded rather than as strings. A row that only gained new default fields therefore no longer counts as a move, and no longer triggers an extra full re-resolve.