read_code with rev rejects a valid git path when its parent directory no longer exists in the working tree #568

New issue

Closed

opened 2026-11-11 07:25:31 +01:00 by buildagent · 1 comment

buildagent commented

2026-11-11 07:25:31 +01:00

Member

Found in worker dogfooding (triage round 14), reproduced on the installed v0.41.48.

Reproduction (in a checkout where crates/cli/tests/fixtures/ was deleted after commit 94a577fa):

code-index query read_code '{"target":"crates/cli/tests/fixtures/legacy-verdict.toml:1-4","rev":"94a577fa","envelope":"minimal"}'

Actual: path_outside_root; the hint rejects absolute or .. components, although the path has neither.

Control: git cat-file -e 94a577fa:crates/cli/tests/fixtures/legacy-verdict.toml exits 0. A historical read of a sibling file whose directory still exists succeeds and reports resolved_commit.

Expected: a rev read validates the project-relative path lexically and reads the git blob, independent of whether the parent directory exists in the working tree.

Impact: a reviewer cannot read a file from a deleted directory through the historical reader, which is the case rev exists for. Related: #558, #555.

Found in worker dogfooding (triage round 14), reproduced on the installed v0.41.48. **Reproduction** (in a checkout where `crates/cli/tests/fixtures/` was deleted after commit `94a577fa`): ``` code-index query read_code '{"target":"crates/cli/tests/fixtures/legacy-verdict.toml:1-4","rev":"94a577fa","envelope":"minimal"}' ``` **Actual:** `path_outside_root`; the hint rejects absolute or `..` components, although the path has neither. **Control:** `git cat-file -e 94a577fa:crates/cli/tests/fixtures/legacy-verdict.toml` exits 0. A historical read of a sibling file whose directory still exists succeeds and reports `resolved_commit`. **Expected:** a `rev` read validates the project-relative path lexically and reads the git blob, independent of whether the parent directory exists in the working tree. **Impact:** a reviewer cannot read a file from a deleted directory through the historical reader, which is the case `rev` exists for. Related: #558, #555.

buildagent referenced this issue

2026-11-12 05:46:24 +01:00

v0.41.50: module evidence for qualified references, one argument contract, one extraction census #574

buildagent referenced this issue from a commit

2026-11-12 11:04:35 +01:00

fix: read historical paths after their parent directory is removed (#568)

buildagent referenced this issue from a commit

2026-11-12 11:04:35 +01:00

fix: route absolute historical reads before lexical validation (#568)

buildagent commented

2026-11-12 11:41:29 +01:00

Author

Member

Released in v0.41.50: read_code with rev reads a path whose directory no longer exists in the working tree.

Verified on the installed binary (code-index 0.41.50 (3d0a584c)): after removing src/ from a committed fixture, read_code {"target":"src/lib.rs:1-3","rev":"HEAD"} returns the committed lines. Closing.

Released in v0.41.50: `read_code` with `rev` reads a path whose directory no longer exists in the working tree. Verified on the installed binary (`code-index 0.41.50 (3d0a584c)`): after removing `src/` from a committed fixture, `read_code {"target":"src/lib.rs:1-3","rev":"HEAD"}` returns the committed lines. Closing.

buildagent closed this issue

2026-11-12 11:41:46 +01:00

buildagent referenced this issue

2026-11-12 14:14:07 +01:00

read_code answers path_outside_root for a missing file whose directory does not exist #578