CI supply-chain retry loop reports success after cargo-deny failures #457
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#457
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Observed normal CI6618/job49109: three cargo-deny attempts reported actual advisory/license errors; the step printed
cargo deny failed after 3 attempts (exit 0)and the job succeeded. In ci.yml the failed command is the condition of an if without an else;$?afterfiis zero, so the saved status and final exit silently pass. Release blocker: capture the command's status in its else branch, and execute the actual workflow run block against failing/retrying/success mocks to prove nonzero failures survive. Do not waive findings or loosen deny.toml.Deterministic RED/GREEN proof is committed in
f859ba8d(PR455):cargo test -p code-index-indexer --test ci_deny_exit_statusexecutes the actual ci.yml run block under bash -e/pipefail. Before the fix, three mocked exit17 failures produced exit0; after capturing status in the else branch, persistent failure preserves17, transient failure succeeds on attempt3, and immediate success runs once. All3 controls pass. No retry or security policy was relaxed. Final normal CI is starting on this corrected tree.