CI supply-chain retry loop reports success after cargo-deny failures #457

Closed
opened 2026-10-24 19:54:31 +02:00 by buildagent · 1 comment
Member

Observed normal CI6618/job49109: three cargo-deny attempts reported actual advisory/license errors; the step printed cargo deny failed after 3 attempts (exit 0) and the job succeeded. In ci.yml the failed command is the condition of an if without an else; $? after fi is zero, so the saved status and final exit silently pass. Release blocker: capture the command's status in its else branch, and execute the actual workflow run block against failing/retrying/success mocks to prove nonzero failures survive. Do not waive findings or loosen deny.toml.

Observed normal CI6618/job49109: three cargo-deny attempts reported actual advisory/license errors; the step printed `cargo deny failed after 3 attempts (exit 0)` and the job succeeded. In ci.yml the failed command is the condition of an if without an else; `$?` after `fi` is zero, so the saved status and final exit silently pass. Release blocker: capture the command's status in its else branch, and execute the actual workflow run block against failing/retrying/success mocks to prove nonzero failures survive. Do not waive findings or loosen deny.toml.
Author
Member

Deterministic RED/GREEN proof is committed in f859ba8d (PR455): cargo test -p code-index-indexer --test ci_deny_exit_status executes the actual ci.yml run block under bash -e/pipefail. Before the fix, three mocked exit17 failures produced exit0; after capturing status in the else branch, persistent failure preserves17, transient failure succeeds on attempt3, and immediate success runs once. All3 controls pass. No retry or security policy was relaxed. Final normal CI is starting on this corrected tree.

Deterministic RED/GREEN proof is committed in f859ba8d (PR455): `cargo test -p code-index-indexer --test ci_deny_exit_status` executes the actual ci.yml run block under bash -e/pipefail. Before the fix, three mocked exit17 failures produced exit0; after capturing status in the else branch, persistent failure preserves17, transient failure succeeds on attempt3, and immediate success runs once. All3 controls pass. No retry or security policy was relaxed. Final normal CI is starting on this corrected tree.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index#457
No description provided.