changed_symbols over a commit range is too large to use (~112k chars concise) and has no path filter #356

Closed
opened 2026-10-12 08:00:43 +02:00 by buildagent · 1 comment
Member

Field report (zammad-dev, 2026-10-12)

Seven review agents reviewed a 46-commit range (323 files, HEAD 68f8c89b99) in /opt/zammad-dev. changed_symbols over that range returned about 112k characters even with response_format: "concise". That is too large to use, so the agents fell back to git diff plus greps for the range review, which is the exact workflow changed_symbols/review_diff exist to replace.

Ask

  • A path_glob filter, like the one search_text/list_files take, so a reviewer can take a range one area at a time.
  • And/or paging by file with a cursor, so the first page is bounded and the reply says how many files remain.
  • Whichever we choose, the reply must state what it left out: a truncated or filtered answer must not read as "these are all the changes".

To check

  • What dominates the 112k: the symbol rows, repeated per-file envelopes, or disclosures.
  • Whether review_diff has the same problem on the same range.

🤖 Generated with Claude Code

## Field report (zammad-dev, 2026-10-12) Seven review agents reviewed a 46-commit range (323 files, HEAD 68f8c89b99) in /opt/zammad-dev. `changed_symbols` over that range returned about **112k characters even with `response_format: "concise"`**. That is too large to use, so the agents fell back to `git diff` plus greps for the range review, which is the exact workflow `changed_symbols`/`review_diff` exist to replace. ## Ask - A `path_glob` filter, like the one `search_text`/`list_files` take, so a reviewer can take a range one area at a time. - And/or paging by file with a cursor, so the first page is bounded and the reply says how many files remain. - Whichever we choose, the reply must state what it left out: a truncated or filtered answer must not read as "these are all the changes". ## To check - What dominates the 112k: the symbol rows, repeated per-file envelopes, or disclosures. - Whether `review_diff` has the same problem on the same range. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
Member

Released in v0.37.0 (tag on e182fccb, release run 1128 green). The fix came in with #360.

changed_symbols and review_diff now take path_glob and page by file with a cursor. If the tree changes while you page, the cursor is refused as invalid_cursor, with a hint to re-run.

Measured on the release binary over v0.36.1..v0.37.0 (49 commits):

  • changed_symbols returned 9 pages of at most 27 KB each.
  • They covered exactly the 130 files git diff --name-only reports, with no file missing or repeated.
  • review_diff paged the same way, in 9 pages.

Closing.

Released in **v0.37.0** (tag on e182fccb, release run 1128 green). The fix came in with #360. `changed_symbols` and `review_diff` now take `path_glob` and page by file with a cursor. If the tree changes while you page, the cursor is refused as `invalid_cursor`, with a hint to re-run. Measured on the release binary over v0.36.1..v0.37.0 (49 commits): - `changed_symbols` returned 9 pages of at most 27 KB each. - They covered exactly the 130 files `git diff --name-only` reports, with no file missing or repeated. - `review_diff` paged the same way, in 9 pages. Closing.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index#356
No description provided.