Field (zammad-dev): review_diff silently omits untracked files; path_glob silently matches nothing for brace patterns {a,b} #329
Labels
No labels
code-review
correctness
dos
performance
security
severity/high
severity/low
severity/medium
tech-debt
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
h-dv/code-index#329
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is a field report from zammad-dev (A1X code-index-dev, 2026-10-07), running v0.33.1. It has not yet been reproduced here.
1.
review_diffleaves out untracked files, and the reply doesn't say soA review of new work covered only generated files. It became complete only after the agent staged everything and passed
staged:true.The reporter suggests either:
Either way, the omission has to be disclosed in the payload.
2.
path_globhas no brace expansion, and fails silentlyA pattern such as
{a,b}matches nothing and gives no error. A glob feature we don't support must be refused by name, not answered with an empty result. That is the same honesty rule as the trigram-floor disclosure insearch_text.Released in v0.34.0 (https://git.h-dv.de/h-dv/code-index/releases/tag/v0.34.0), via PR #333.
c727b5aa):coverage.untracked_reviewsaysreviewed_as_added.staged=trueit saysexcluded_by_staged, counts the files it did not review, and names the fix.874e941c):search_text,search_symbols,list_filesandresolution_gapsrefuse a{a,b}brace group withunsupported_glob_syntax. The hint lists every pattern the group would expand to, up to 16. A brace without a comma is still treated as a literal path.Brace expansion itself is not implemented; it is recorded as a follow-up.