Field (zammad-dev): review_diff silently omits untracked files; path_glob silently matches nothing for brace patterns {a,b} #329

Closed
opened 2026-10-07 08:59:40 +02:00 by buildagent · 1 comment
Member

This is a field report from zammad-dev (A1X code-index-dev, 2026-10-07), running v0.33.1. It has not yet been reproduced here.

1. review_diff leaves out untracked files, and the reply doesn't say so

A review of new work covered only generated files. It became complete only after the agent staged everything and passed staged:true.

The reporter suggests either:

  • including untracked files, or
  • stating in the payload that untracked files were excluded, and how many.

Either way, the omission has to be disclosed in the payload.

2. path_glob has no brace expansion, and fails silently

A pattern such as {a,b} matches nothing and gives no error. A glob feature we don't support must be refused by name, not answered with an empty result. That is the same honesty rule as the trigram-floor disclosure in search_text.

This is a field report from zammad-dev (A1X code-index-dev, 2026-10-07), running v0.33.1. It has **not yet been reproduced here.** ## 1. `review_diff` leaves out untracked files, and the reply doesn't say so A review of new work covered only generated files. It became complete only after the agent staged everything and passed `staged:true`. The reporter suggests either: - including untracked files, or - stating in the payload that untracked files were excluded, and how many. Either way, the omission has to be disclosed in the payload. ## 2. `path_glob` has no brace expansion, and fails silently A pattern such as `{a,b}` matches nothing and gives no error. A glob feature we don't support must be refused by name, not answered with an empty result. That is the same honesty rule as the trigram-floor disclosure in `search_text`.
Author
Member

Released in v0.34.0 (https://git.h-dv.de/h-dv/code-index/releases/tag/v0.34.0), via PR #333.

  • (a) review_diff (c727b5aa):
    • In working-tree mode, untracked files are reviewed as whole-file additions, and coverage.untracked_review says reviewed_as_added.
    • With staged=true it says excluded_by_staged, counts the files it did not review, and names the fix.
  • (b) path_glob (874e941c): search_text, search_symbols, list_files and resolution_gaps refuse a {a,b} brace group with unsupported_glob_syntax. The hint lists every pattern the group would expand to, up to 16. A brace without a comma is still treated as a literal path.

Brace expansion itself is not implemented; it is recorded as a follow-up.

Released in v0.34.0 (https://git.h-dv.de/h-dv/code-index/releases/tag/v0.34.0), via PR #333. - **(a) review_diff** (c727b5aa): - In working-tree mode, untracked files are reviewed as whole-file additions, and `coverage.untracked_review` says `reviewed_as_added`. - With `staged=true` it says `excluded_by_staged`, counts the files it did not review, and names the fix. - **(b) path_glob** (874e941c): `search_text`, `search_symbols`, `list_files` and `resolution_gaps` refuse a `{a,b}` brace group with `unsupported_glob_syntax`. The hint lists every pattern the group would expand to, up to 16. A brace without a comma is still treated as a literal path. Brace expansion itself is not implemented; it is recorded as a follow-up.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
h-dv/code-index#329
No description provided.