feat: refactor preflight — safe_delete + check_rename #25

New issue

Closed

opened 2026-07-20 22:38:07 +02:00 by buildagent · 1 comment

buildagent commented

2026-07-20 22:38:07 +02:00

Member

Rank 4 of the 2026-07-20 index-data brainstorm (_prdoc/records/brainstorm-2026-07-20-index-data-catalog.md).

What: two checked-transaction tools for the riskiest agent edits. safe_delete(symbol): typed refs + name fallbacks + trigram-FTS pass for string-embedded references + newly-orphaned-callee cascade preview. check_rename(old, new): collision and ambiguity-injection detection before compile time — critical for the 4 dynamic languages with no compiler backstop.

Why — the killer case: roles_is_zero (daemon local_index.rs) has ref_count=0 and zero edges — every ref-based detector calls it dead — but FTS finds it inside #[serde(skip_serializing_if = "roles_is_zero")]; deleting it compiles and silently breaks serialization. Rename side: new has 18 same-name symbols, parse 11 — collision injection is a real hazard. Validated: try_resolve→resolve clean (0 collisions, 3-ref edit manifest); Writer::upsert_file verdict "safe, doc update at writer.rs:3" (exactly what v0.5.19 did manually).

Cost: small — 3-4 indexed queries per call (refs by target, refs by name, files_fts MATCH, symbol_edges CTE); no new data.

Rank 4 of the 2026-07-20 index-data brainstorm (`_prdoc/records/brainstorm-2026-07-20-index-data-catalog.md`). **What**: two checked-transaction tools for the riskiest agent edits. `safe_delete(symbol)`: typed refs + name fallbacks + **trigram-FTS pass for string-embedded references** + newly-orphaned-callee cascade preview. `check_rename(old, new)`: collision and ambiguity-injection detection before compile time — critical for the 4 dynamic languages with no compiler backstop. **Why — the killer case**: `roles_is_zero` (daemon local_index.rs) has ref_count=0 and zero edges — every ref-based detector calls it dead — but FTS finds it inside `#[serde(skip_serializing_if = "roles_is_zero")]`; deleting it compiles and silently breaks serialization. Rename side: `new` has 18 same-name symbols, `parse` 11 — collision injection is a real hazard. Validated: `try_resolve→resolve` clean (0 collisions, 3-ref edit manifest); `Writer::upsert_file` verdict "safe, doc update at writer.rs:3" (exactly what v0.5.19 did manually). **Cost**: small — 3-4 indexed queries per call (refs by target, refs by name, files_fts MATCH, symbol_edges CTE); no new data.

buildagent referenced this issue from a commit

2026-07-21 11:50:43 +02:00

docs(prdoc): file mission I030 — Agent Change Safety v1 (#29 #25 #34, fixed design)

buildagent commented

2026-07-21 11:51:06 +02:00

Author

Member

Shipped in v0.6.0 (I030 Track B) as safe_delete + check_rename. Evidence tools with stable severity-ordered reason codes and a contractual never-say-"safe": resolved refs with prod/test split, string evidence via trigram-FTS candidates word-boundary-verified against stored content (the defining-file serde case surfaces — unit-tested on the roles_is_zero shape), dark-channel disclosure for sub-3-char names, newly-orphaned callees, scoped collisions (PHP case-insensitive), ambiguity-injection counts, full edit manifests, every cap honest. Bench: delete-prep = 1 call / 1.2KB surfacing 6 refs + 8 string files on this repo.

Shipped in **v0.6.0** (I030 Track B) as `safe_delete` + `check_rename`. Evidence tools with stable severity-ordered reason codes and a contractual never-say-"safe": resolved refs with prod/test split, string evidence via trigram-FTS candidates **word-boundary-verified** against stored content (the defining-file serde case surfaces — unit-tested on the `roles_is_zero` shape), dark-channel disclosure for sub-3-char names, newly-orphaned callees, scoped collisions (PHP case-insensitive), ambiguity-injection counts, full edit manifests, every cap honest. Bench: delete-prep = 1 call / 1.2KB surfacing 6 refs + 8 string files on this repo.

buildagent closed this issue

2026-07-21 11:51:17 +02:00

buildagent referenced this issue

2026-07-21 14:26:47 +02:00

feat: find_dead_symbols — confidence-tiered dead/test-only-code detector with reason codes #24